On Wed, May 21, 2025 at 3:44 AM Tomas Vondra <to...@vondra.me> wrote: > On 5/20/25 05:06, Tom Lane wrote: > > Amit Langote <amitlangot...@gmail.com> writes: > >> Pushed after some tweaks to comments and the test case. > > > > My attention was drawn to commit 525392d57 after observing that > > Valgrind complained about a memory leak in some code that commit added > > to BuildCachedPlan(). I tried to make sense of said code so I could > > remove the leak, and eventually arrived at the attached patch, which > > is part of a series of leak-fixing things hence the high sequence > > number. > > > > Unfortunately, the bad things I speculated about in the added comments > > seem to be reality. The second attached file is a test case that > > triggers > > > > ... > > FYI I added this as a PG18 open item: > > https://wiki.postgresql.org/wiki/PostgreSQL_18_Open_Items
Thanks Tomas. -- Thanks, Amit Langote