On Thu, May 8, 2025 at 11:20 PM Nathan Bossart <nathandboss...@gmail.com> wrote: > > On Thu, May 08, 2025 at 10:38:04PM +0900, Ian Lawrence Barwick wrote: > > Revised patch attached which adds coverage of that and also for the > > "constant of the type reg(role|database) cannot be used here" error. > > LGTM. I've marked it as ready-for-committer [0] and will plan on > committing it as soon as v19 development begins. > > [0] https://commitfest.postgresql.org/patch/5746/ >
hi. I saw REGROLEOID in foreign_expr_walker, I'm wondering whether REGDATABASEOID is reachable within foreign_expr_walker. not familiar with this area, also there are no coverage tests for other reg*Const, per https://coverage.postgresql.org/contrib/postgres_fdw/deparse.c.gcov.html