On Wed, May 7, 2025 at 8:15 PM Aleksander Alekseev <aleksan...@timescale.com> wrote: > > I didn't review the patch but wanted to point out that when it comes > to performance improvements it's typically useful to provide some > benchmarks.
+1 -- It's good to have concrete numbers for the commit message, and also to verify improvement on short inputs. There is a test harness in the v7-0002 patch from here: https://www.postgresql.org/message-id/canwcazad5niydbf6q3v_cjapnv05cw-lpxxftmbwdplsz-p...@mail.gmail.com After building, run the "test-crc.sh" script here after executing "CREATE EXTENSION test_crc32c;": https://www.postgresql.org/message-id/CANWCAZahvhE-%2BhtZiUyzPiS5e45ukx5877mD-dHr-KSX6LcdjQ%40mail.gmail.com -- John Naylor Amazon Web Services
