On Wed, May 7, 2025 at 03:03:32PM +0900, Richard Guo wrote: > On Fri, May 2, 2025 at 11:44 AM Bruce Momjian <br...@momjian.us> wrote: > > > > I have committd the first draft of the PG 18 release notes. > > > I will continue improving it until beta 1, and until the final release. > > I will probably add markup in 1-3 weeks. Let the feedback begin. ;-) > > Thanks for working on these. > > I'm wondering if we should consider mentioning that several > long-standing issues related to grouping sets have been fixed starting > from PostgreSQL v18. I understand that we typically don't include bug > fixes in the release notes, but these particular issues have been > present since grouping sets were first introduced, and currently they > still exist in the back branches (yeah, for some reason we do not have > back-branch fixes; we only fix them in v18 and going forward). > > There have been complaints from users about grouping sets giving > incorrect results in certain cases, which has made them hesitant to > use PostgreSQL for analytical workloads. Since these issues are fixed > in v18, it might be worthwhile to point this out — if only to reassure > users that these issues are no longer a concern going forward. > > (FWIW, the related commits are 247dea89f, f5050f795, and cc5d98525).
Agreed, any fix that commonly used to return wrong results should be mentioned. Applied patch attached. -- Bruce Momjian <br...@momjian.us> https://momjian.us EDB https://enterprisedb.com Do not let urgent matters crowd out time for investment in the future.
diff --git a/doc/src/sgml/release-18.sgml b/doc/src/sgml/release-18.sgml index 80cf415bb76..c153c841dc2 100644 --- a/doc/src/sgml/release-18.sgml +++ b/doc/src/sgml/release-18.sgml @@ -304,6 +304,12 @@ from the grouping. This was already true for non-deferred primary keys. <!-- Author: Richard Guo <r...@postgresql.org> 2024-10-09 [67a54b9e8] Allow pushdown of HAVING clauses with grouping sets +Author: Richard Guo <r...@postgresql.org> +2024-09-10 [247dea89f] Introduce an RTE for the grouping step +Author: Richard Guo <r...@postgresql.org> +2024-09-10 [f5050f795] Mark expressions nullable by grouping sets +Author: Richard Guo <r...@postgresql.org> +2025-03-13 [cc5d98525] Fix incorrect handling of subquery pullup --> <listitem> @@ -313,7 +319,7 @@ Allow some HAVING clauses on GROUPING SETS to be pushed to WHERE clauses (Richar </para> <para> -This allows earlier row filtering. +This allows earlier row filtering. This release also fixes some GROUPING SETS queries that used to return incorrect results. </para> </listitem>
