On Wed, May 07, 2025 at 08:00:39AM +0900, Michael Paquier wrote: > On Tue, May 06, 2025 at 11:41:49AM -0500, Nathan Bossart wrote: >> I brought this up with the RMT, and everyone seemed okay with committing it >> for v18. > > Cool, thanks for the update. > >> I can move it back to replorigin_create(). I don't have a strong opinion >> here. > > I think that I would the check there, as that's safer in the long-run > to enforce the rule to all potential callers of this API. If the > votes balance in favor of keeping it in the SQL function, that's OK by > me as well, so feel free to ignore me if you feel strongly about it > overall.
Committed with that change. That takes care of a good chunk of these TOAST snapshot problems. I think there are about 4 others left, unless something has changed since I last checked. I hope to look into those again soon. -- nathan
