Hi, On Wed, May 07, 2025 at 09:10:17AM +0900, Michael Paquier wrote: > On Mon, May 05, 2025 at 04:33:20PM +0300, Ilia Evdokimov wrote: > > While reviewing the import/export statistics, I noticed that relation > > locking are handled via relation_open() and relation_close() in > > stats_lock_check_privileges(), and no calls to other lock-manager routines > > are actually used there. As a result, the inclusion of the lock-manager > > header > > > > #include "storage/lmgr.h" > > > > is not needed. I have attached a small patch which simply removes that > > include. > > True that we try to be clean when it comes to that.
Re-sharing my thoughts as it looks like that my previous email did not reach the mailing list (yet?): probably because the attachement mentioned below was too large. " Thanks for the report! Indeed, and that's what clang-tidy (misc-include-cleaner) also reports: $ run-clang-tidy -checks="-*,misc-include-cleaner" | grep "is not used directly" | grep stat_utils.c ../src/backend/statistics/stat_utils.c:26:1: warning: included header lmgr.h is not used directly [misc-include-cleaner] Actually it reports much more (see attached): $ run-clang-tidy -checks="-*,misc-include-cleaner" | grep -c "is not used directly" 794 I did not look to check if all of them make sense (I'd guess probably not), but I'm wondering if it would make sense to work an a "larger" cleanup instead? (in the same vein as [1] did) [1]: https://www.postgresql.org/message-id/af837490-6b2f-46df-ba05-37ea6a6653fc%40eisentraut.org " Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
