While working on [1] I found an outdated comment in heap_page_is_all_visible() 
and two other small fixes.

0001: Updates that comment so future authors know that this "stripped down 
function" should retain the logic in heap_page_prune_and_freeze(), not 
lazy_scan_prune() as was the case before 6dbb490.
0002: Mimics the same loop logic as in heap_page_is_all_visible() so as to a) 
stay in sync and b) benefit from the mentioned CPU prefetching optimization.
0003: Moves the ItemSetPointer() just a bit further down in the function again 
to a) stay in sync and b) to sometimes avoid that tiny overhead.

best,

-greg

PS: per-community standards I've switched to my personal email address rather 
than gregb...@amazon.com

[1] 
https://www.postgresql.org/message-id/flat/78574b24-be0a-42c5-8075-3fa9fa63b...@amazon.com

Attachment: v1-0001-Fix-references-in-comments-in-heap_page_is_all_vi.patch
Description: Binary data

Attachment: v1-0003-Move-ItemPointerSet-call-to-better-match-heap_pag.patch
Description: Binary data

Attachment: v1-0002-Reverse-loop-to-match-counterpart-and-optimize-fo.patch
Description: Binary data

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to