On Sat, May 3, 2025 at 01:16:24PM +0200, Jelte Fennema-Nio wrote: > On Sat, 3 May 2025 at 02:06, Bruce Momjian <br...@momjian.us> wrote: > > > > On Sat, May 3, 2025 at 01:46:29AM +0200, Jelte Fennema-Nio wrote: > > > On Fri, 2 May 2025 at 04:45, Bruce Momjian <br...@momjian.us> wrote: > > > > > > > > I have committd the first draft of the PG 18 release notes. The item > > > > count looks strong: > > > > > > Thanks for all the work. Some notes: > > > > > > 1. There's currently no mention that protocol version 3.2 was > > > introduced in this release. I'm not sure where/how this should be > > > mentioned, but I definitely think it should be somewhere. It's a > > > pretty major change. One option is to replace/amend the "Make cancel > > > request keys 256 bits" item. Maybe replace that with something like: > > > "Postgres 18 introduces protocol version 3.2. This is the first new > > > protocol version since 3.0, which was introduced in Postgres 7.4. This > > > new protocol version 3.2 allows a server to use longer cancel request > > > keys. When the client advertises support for protocol version 3.2 (or > > > higher) Postgres 18 will use a cancel key size of 256 bits." > > > > Okay, I added a mention next to the libpq version function entries. > > I think it should be mentioned in the server section. How about we > replace: "This is enabled when the libpq client and server are > Postgres 18 or later. ", with the following: > > This is only enabled when the client supports the wire protocol > version 3.2 (or up), Wire protocol version 3.2 is introduced in this > release. For libpq based clients that means that libpq needs to be of > version 18 or higher. > > That also makes it clear that for non-libpq based clients people > should check if their client supports it.
I moved the item and added some text, patch attached. -- Bruce Momjian <br...@momjian.us> https://momjian.us EDB https://enterprisedb.com Do not let urgent matters crowd out time for investment in the future.
diff --git a/doc/src/sgml/release-18.sgml b/doc/src/sgml/release-18.sgml index 3519ff87705..66cdeb67961 100644 --- a/doc/src/sgml/release-18.sgml +++ b/doc/src/sgml/release-18.sgml @@ -1113,7 +1113,7 @@ Make cancel request keys 256 bits (Heikki Linnakangas) </para> <para> -This is enabled when the libpq client and server are Postgres 18 or later. +This is only possible when the server and cliient support wire protocol version 3.2, introduced in this release. </para> </listitem> @@ -2146,10 +2146,6 @@ Author: Robert Haas <rh...@postgresql.org> Add function PQfullProtocolVersion() to report the full, including minor, protocol version number (Jacob Champion, Jelte Fennema-Nio) <ulink url="&commit_baseurl;cdb6b0fdb">§</ulink> </para> - -<para> -This release introduces wire protocol version 3.2. -</para> </listitem> <!--
