Thanks for the feedback, Thomas.

> No comment on the wider project except that it looks generally useful,
> and I can see that it's not possible to use the conventional POSIX
> filename "-" to represent stdout, because you need to write to
> multiple files so you need to come up with *something* along the lines
> you're proposing here.  But I was interested in seeing if I could help
> with that technical problem you mentioned above, and I don't see that
> happening with the current patches.  Do I understand correctly that
> the problem you encountered is in some other tests that you haven't
> attached yet?  Could you post what you have so that others can see the
> problem and perhaps have a chance of helping?

Yes, we didn't add the failed tests to the patch. We'll add those and
send new patches.

> I also recommend using
> git format-patch when you post patches so that you have a place to
> write a commit message including a note about which bits are WIP and
> known not to work correctly yet.

Will follow these recommendations when sending the next set of patches.

Regards,
Nitin Motiani
Google


Reply via email to