On Wed, Apr 23, 2025 at 10:33 AM David G. Johnston <david.g.johns...@gmail.com> wrote: ... > In the column list I would stick to mentioning what cannot be specified, > since it would be assumed by default that any column on the table is fair > game. I believe that means not mentioning stored generated and instead > mentioning virtual generated. It really seems odds mentioning stored > generated being allowed before mentioning when they are optional, default > excluded. > > Alternative: > > The optional column list may include any non-virtual columns of the table. > If omitted, tables publish all (including future) non-generated columns by > default, and may publish stored generated columns if the publication option > publish_generated_columns is set to stored. See Section 29.5 for details > about column lists. > > > I don’t get why truncate is mentioned here. I omitted it intentionally. >
Hi David, Thanks for your feedback/suggestions. Sorry for my late reply -- I was waiting for any other feedback, but none was forthcoming, so here is my patch v2. I've rearranged the text and mentioned non-virtual and non-generated as suggested. I also did not really understand why TRUNCATE is mentioned in this paragraph, but I have left that as-is for now. For this thread, I only wanted to address the generated column issue. I think any removal of the TRUNCATE note ought to be handled separately, where more effort can be spent to understand why it was put there in the first place. Anyway, PSA patch v2. ====== Kind Regards, Peter Smith. Fujitsu Australia
v2-0001-DOCS-create-publication-for-table.patch
Description: Binary data
