On Sat, Apr 19, 2025 at 2:15 PM Daniel Gustafsson <dan...@yesql.se> wrote: > Since there is no way to determine if the allocation succeeded from outside of > the JSON api it might be better to keep the calloc and explicitly free it?
I don't think so; pg_parse_json() will error out quickly, so I don't see much advantage to the extra code. Raw performance isn't much of a concern for the out-of-memory case, IMO. > (Could a JsonLexContextBroken() function be useful perhaps?) Maybe if there's ever a client that absolutely must initialize a context before doing a bunch of independent work? But I don't think that's true here. (Any callers we're converting from the stack API are going to have short-lived contexts.) --Jacob
