Re: Memory context can be its own parent and child in replication command

[Rahila Syed]

Hi,


So here's a v4 with the test restored.
>

I tested this patch, it fixes the issue reported. It passes Github CI tests.


> already does that, so the only new assert would be in
> MemoryContextCreate.


+1 for adding the assertion to increase the chances of this bug being
caught by memory context infrastructure.

I had the following comment.

Why do we do this:
-       MemoryContext old_context;
+       MemoryContext old_context = CurrentMemoryContext;

Instead of implementing it as done in the previous version of this code,
i.e.
old_context = MemoryContextSwitchTo(cmd_context);

Thank you,
Rahila Syed