On 2025-04-14 Mo 8:20 AM, Álvaro Herrera wrote:
On 2025-Apr-04, Andrew Dunstan wrote:
Non text modes for pg_dumpall, correspondingly change pg_restore
I think the new oid_string_list stuff in this commit is unnecessary, and
we can remove a bunch of lines by simplifying that to using
SimplePtrList, as the attached illustrates. (Perhaps the names of
members of the proposed struct can be improved.)
I also propose to remove the open-coded implementation of pg_get_line.
WDYT?
I'm also not sure about the double sscanf() business there ... There
must be a better way to do this.
Pushed your patch plus cleanup of the sscanf stuff.
Thanks!
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com