> On 15 Apr 2025, at 14:41, Robert Haas <robertmh...@gmail.com> wrote: > > On Tue, Apr 15, 2025 at 3:46 AM Daniel Gustafsson <dan...@yesql.se> wrote: >>> On 15 Apr 2025, at 06:22, Amul Sul <sula...@gmail.com> wrote: >>> Attached is a patch that corrects the code comment for >>> process_directory_recursively() in pg_combinebackup, where the comment >>> incorrectly refers to "output_directory" instead of the intended >>> "input_directory". >> >> Agreed. The second paragraph in the comment also seem a bit odd, how about >> the >> below while we are there fixing things? >> >> - * If processing is a user-defined tablespace, the tsoid should be the OID >> + * If processing a user-defined tablespace, the tsoid should be the OID > > Yeah, I agree with both of these changes. Feel free to commit, unless > you want me to do it.
No worries, I had this staged anyways from looking at Amul's patch so done as 7ae13170ba5 with a backpatch to 17 as it was a documentation fix and not just a typo fix. -- Daniel Gustafsson
