Wolfgang Walther:
> So yes, not related to your patch. I do understand that PostgreSQL's
> autoconf build system is not designed for "static only", I am certainly
> not expecting you to fix that.
>
> I think meson will do better here, but I was not able to make that work,
> yet.
I did a basic meson build. Full postgresql package, not libpq-only.
The static-only build just works. On master that is. Same as the regular
build.
So yes, meson will handle the static stuff much better.
> I just tried the same thing on the bigger postgresql package, where the
> full build is run and not only libpq / libpq-oauth. It fails with the
> same error. No rule for oauth-curl.o.
Applying the v5 patch to the above meson build, will give me a different
error. This time for both the static-only and the regular build:
src/interfaces/libpq-oauth/meson.build:18:22: ERROR: File
oauth-curl.c does not exist.
This.. clears it up, because that file is indeed missing for me on disk.
I assume that's because this file is tracked as a rename in the v5
patch. I can apply this with git, but not directly in the nix build
system. TIL, I need to use "fetchpatch2" instead of "fetchpatch" for
that. Sure thing.
So, with the patch applied correctly, I get the following:
1. Meson regular build:
libpq-oauth-18.so
libpq.so
libpq.so.5
libpq.so.5.18
The libpq.so file has references to dlopen and libpq-auth-18.so, cool.
2. Meson static-only build:
libpq.a
libpq-oauth-18.a
The libpq.a file has no references to dlopen, but plenty of references
to curl stuff.
I'm not sure what the libpq-oauth-18.a file is for.
3. Back to the lipq-only build with autoconf, from where I started. I
only need to add the following line:
make -C src/interfaces/libpq-oauth install
and get this:
libpq-oauth-18.so
libpq.so
libpq.so.5
libpq.so.5.18
Sweet!
4. Of course the static-only build does not work with autoconf, but
that's expected.
So, sorry for the noise before. Now, that I know how to apply patches
with renames, I will try your next patch as well.
Best,
Wolfgang
