In a similar effort to what I did in [1], there's a bunch of appendPQExpBuffer() calls that could use appendPQExpBufferStr() or appendPQExpBufferChar(). With [1], I've been keeping those appendStringInfo calls in check at this time of year for a few years now. With appendPQExpBuffer I've not been, so a bunch of the changes in 0002 touch code that's older than master. In one case as old as v11.
See the attached summary.txt for details on when each of these first appeared. The 0001 patch is the method I used to find these (which is a bit cruddy and not for commit) I'm now wondering if: 1) I should commit the attached 0002 patch now, or; 2) Should commit only the new-to-v18 ones now, or; 3) do nothing. I think #3 isn't a good option as we (or I) have made efforts in the past to keep these in check. Also, for me, #2 isn't ideal as if I do this next year for v19, I'll need to ignore the older inconsistencies, and I'd rather not have to do that, so I vote for #1. Any other opinions? David [1] https://postgr.es/m/CAApHDvqJnNjueb=eoj8k+8n0g7nj_acpwsicj5rnv4fdeja...@mail.gmail.com
initdb.c cccdbc5d95ac REL_17_STABLE pg_createsubscriber.c: d44032d01463 REL_17_STABLE b3f5ccebd79d REL_17_STABLE ac0e33136abc master pg_dump.c: a563c24c9574 REL_16_STABLE b29cbd3da4e3 REL_17_STABLE 9a17be1e244a REL_17_STABLE 5ba4cc309095 REL_17_STABLE a379061a22a8 master 650ab8aaf195 master pg_dumpall.c: 3d14e171e9e2 REL_16_STABLE pg_upgrade.c: 29d0a77fa660 REL_17_STABLE psql/common.c: 49ca462eb165 REL_11_STABLE vacuumdb.c: fb56a181175b REL_17_STABLE fe-auth-oauth-curl.c: b3f0be788afc master test_escape.c: ac00ff1c9608 master
v1-0001-Adjust-code-to-highlight-appendStringInfo-misusag.patch
Description: Binary data
v1-0002-Fixup-various-usages-of-appendPQExpBuffer.patch
Description: Binary data
