On Tue, Oct 22, 2024 at 08:33:24PM +0300, Alexander Korotkov wrote: > On Tue, Oct 22, 2024 at 6:10 PM Pavel Borisov <pashkin.e...@gmail.com> wrote: > > On Tue, 22 Oct 2024 at 11:34, Alexander Korotkov <aekorot...@gmail.com> > > wrote: > >> I'm going to push this if no objections.
(This became commit b85a9d0.) > + /* Call delete_rel_type_cache() if we actually cleared something */ > + if (hadTupDescOrOpclass) > + delete_rel_type_cache_if_needed(typentry); I think the intent was to maintain the invariant that a RelIdToTypeIdCacheHash entry exists if and only if certain kinds of data appear in the TypeCacheHash entry. However, TypeCacheOpcCallback() clears TCFLAGS_OPERATOR_FLAGS without maintaining RelIdToTypeIdCacheHash. Is it right to do that?
