On Thu, Apr 10, 2025 at 11:58:41PM +0530, Mahendra Singh Thalor wrote: > As per above discussions, for v18, we will not do any change to server > side to fix the issue of \n\r in database names. But as a cleanup > patch, we can give an alert to the user by "pg_upgrade --check". As > per current code, pg_dump and pg_upgrade will fail with "shell > command" error but in the attached patch, we will give some extra info > to the user by "pg_upgrade --check" so that they can fix database > names before trying to upgrade. > > Here, I am attaching a patch which will give a list of invalid > database names in "pg_upgrade --check". We can consider this as a > cleanup patch.
Are you proposing this for v18? I think this is all v19 material at this point. Perhaps we could argue this is a bug fix that should be back-patched, but IMHO that's a bit of a stretch. I don't sense a tremendous amount of urgency, either. -- nathan
