On Sun, Feb 9, 2025 at 2:11 AM Pavel Luzanov <p.luza...@postgrespro.ru> wrote:
> > I don't understand from new commitfest transition guidance > what to do with status of commitfest entry in this case. > May be it needs to be closed. And in a case I will be able to propose > a new version, I will open a new entry. > > The commitfest entry now has Needs Review status and stayed in > the closed January commitfest. > > 0. > https://www.postgresql.org/message-id/flat/003e3a66-8fcc-4ca0-9e0e-c0afda1c9424%40eisentraut.org > 1. https://commitfest.postgresql.org/51/4738/ > 2. > https://www.postgresql.org/message-id/5341835b-e7be-44dc-b6e5-400e9e3f3...@postgrespro.ru > 3. > https://www.postgresql.org/message-id/CA%2BTgmoZ_uGDb3N8AKHG6nOc5HZPp5Y_ogFhrRbhoVnPHN%2B4t3g%40mail.gmail.com > > As author it is encouraged that you decide whether Waiting on Author or Withdrawn is the desired status for this patch if you do not want it, as presented, to be committed. If you are content with it being committed as-is it should be marked Review Needed in an Open Commitfest. Abandoning this approach and going for what Robert suggested would suggest withdrawing this CF entry. However, I do think we are at something committable, though I'd make one, maybe two, changes to v8. Valid until -> Password valid until: the timestamp value already forces a wide column, adding the word Password to the header to clarify what is valid simply provides the same context that the create role page provides when it shows the valid until attribute immediately below the password attribute. Leaving "valid until" alone retains the attribute name tieback. Connection limit -> Con. limit: maybe this gets rejected on translation grounds but the abbreviation here seems obvious and shaves 7 characters off the mandatory width for a column that occupies 12 characters more than the values require. Even without those changes I as reviewer would concur with the proposal and try to move this on from bike-shedding to a go/no-go decision (by marking it Ready to Commit) as to whether this is an improvement over the status quo. David J.
