On Tue, Apr 08, 2025 at 06:19:02AM +0000, Bertrand Drouvot wrote: > - A new injection_points_wakeup_detach() function that is holding the spinlock > during the whole duration to ensure that no process can wait in between the > wakeup and the detach.
That would not a correct spinlock use. injection_points_detach() and injection_points_wakeup_internal() do much more actions than what we can internally do while holding a spinlock, including both Postgres-specific calls as well as system calls. strcmp() and strlcpy() are still OK-ish, even as system calls, as they work directly on the strings given in input. -- Michael
signature.asc
Description: PGP signature
