On Thu, Mar 20, 2025 at 11:13 AM Nathan Bossart <nathandboss...@gmail.com> wrote:
> > How does something like this look for the comment? > > /* > * isset_offset is an optional offset of a field in the result > struct > * that stores whether the value is explicitly set for the > relation or > * has just picked up the default value. In most cases, this can > be > * deduced by giving the reloption a special default value (e.g., > -2 is > * a common one for integer reloptions), but this isn't always > * possible. One notable example is Boolean reloptions, where it's > * difficult to discern the source of the value. This offset is > only > * used if given a value greater than zero. > */ > int isset_offset; > > > I didn't actually come back to this before writing my comment. I'm glad they both say basically the same thing. I'm still partial to mine but yours probably fits the overall style of the codebase better. David J.
