On Fri, Apr 4, 2025 at 1:02 AM Alexander Korotkov <aekorot...@gmail.com> wrote: > I've got an off-list bug report from Alexander Lakhin involving a > placeholder variable. Alena and Andrei proposed a fix. It is fairly > simple: we just shouldn't remove PHVs during self-join elimination, as > they might still be referenced from other parts of a query. The patch > is attached. I'm going to fix this if no objections.
Hmm, I'm not sure about the fix. It seems to me that it simply prevents removing any PHVs in the self-join removal case. My concern is that this might result in PHVs that could actually be removed not being removed in many cases. Besides, there's the specific comment above this code explaining the logic behind the removal of PHVs. Shouldn't that comment be updated to reflect the changes? Thanks Richard
