On Fri, 28 Mar 2025 at 16:35, Álvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > > On 2025-Mar-28, Shlok Kyal wrote: > > > On Mon, 24 Mar 2025 at 21:17, Álvaro Herrera <alvhe...@alvh.no-ip.org> > > wrote: > > > > Also, surely we should document this restriction in the SGML docs > > > somewhere. > > > > I have added comment in create_publication.sgml > > Hmm, okay, but "We cannot" is not the style used in the documentation. > In addition, I think this mechanism should be mentioned in > logical-replication.sgml; currently there's a note in the Restrictions > section about foreign tables, which should be expanded to explain this. >
I have modified the comment in create_publication.sgml and also added comment in the restrictions section of logical-replication.sgml. I have also added a more detailed explanation in comment of 'check_foreign_tables' I have attached the updated v11 patch. Thanks and Regards, Shlok Kyal
v11-0001-Restrict-publishing-of-partitioned-table-with-fo.patch
Description: Binary data
