>> They can be, but currently they might not be. So this requires at least >> big fat warning in docs and description on how to access user catalogs >> from plugins correctly (ie to always use systable_* API on them). It >> would be nice if we could check for it in Assert builds at least. >
Ok, modified the sgml documentation for the above. > Yea, I agree. I think we should just consider putting similar checks in > the general scan APIs. With an unlikely() and the easy predictability of > these checks, I think we should be fine, overhead-wise. > Ok, added unlikely() checks in the heap_* scan APIs. Revised patchset attached. Regards, Nikhils > Greetings, > > Andres Freund -- Nikhil Sontakke http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
0001-Cleaning-up-of-flags-in-ReorderBufferTXN-structure.patch
Description: Binary data
0002-Support-decoding-of-two-phase-transactions-at-PREPAR.patch
Description: Binary data
0003-Gracefully-handle-concurrent-aborts-of-uncommitted-t.patch
Description: Binary data
0004-Teach-test_decoding-plugin-to-work-with-2PC.patch
Description: Binary data
