On Tue, Mar 25, 2025 at 09:41:21PM +1300, Thomas Munro wrote: > On Wed, Mar 5, 2025 at 6:00 AM Peter Eisentraut <pe...@eisentraut.org> wrote: >> I agree with your patch 0001-Deprecate-pg_int64.patch. I don't see a >> reason to keep the current arrangement around pg_int64. > > Thanks for looking! Pushed.
anaconda seems to be upset about this one [0]. I've spent all of 30 seconds looking at it so far, but it appears to be using an old version of the header file. In file included from pg_regress.c:34: /usr/local/include/libpq-fe.h:623:8: error: unknown type name 'pg_int64' 623 | extern pg_int64 lo_lseek64(PGconn *conn, int fd, pg_int64 offset, int whence); | ^ /usr/local/include/libpq-fe.h:623:50: error: unknown type name 'pg_int64' 623 | extern pg_int64 lo_lseek64(PGconn *conn, int fd, pg_int64 offset, int whence); | ^ /usr/local/include/libpq-fe.h:627:8: error: unknown type name 'pg_int64' 627 | extern pg_int64 lo_tell64(PGconn *conn, int fd); | ^ /usr/local/include/libpq-fe.h:629:48: error: unknown type name 'pg_int64' 629 | extern int lo_truncate64(PGconn *conn, int fd, pg_int64 len); | ^ 4 errors generated. [0] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=anaconda&dt=2025-03-25%2021%3A22%3A33 -- nathan