On Sat, Mar 22, 2025 at 10:49 AM Tom Lane <t...@sss.pgh.pa.us> wrote: > > Personally, I think it'd be most useful for the dashboard to show all > > open patches. > > Surely not "all"? We have that display already. Should be more like > "patches that I have expressed an interest in or have reason to take > current or future action on".
What I meant was "patches that I have expressed an interest in or have reason to take current or future action on" should be interpreted in the broadest/most permissive way possible by the dashboard. In particular, entries should only *fully* disappear when somebody (some individual human) has actively chosen to make a representation that the patch is closed out. The rest (how we present that information) is details. > In the case of stale patches that haven't been moved forward from a > closed commitfest, perhaps we could compromise on Jelte's suggestion > of putting those in a separate section at the bottom of the page. If there is any gray area, then I very much want us to err on the side of still showing *something*. I really strongly object to having things vanish, absent a 100% unambiguous signal that that's what should happen. In general, the personal dashboard is (quite usefully) oriented around what actions you as a user (or some other CF app user) needs to take -- it is workflow oriented. It seems natural to me to handle stale/in limbo patches (patches that are not officially closed but also aren't in the current or next CF) in just the same way -- by presenting the information in terms of actions that need to be taken by some individual stakeholder. > However, I still think such patches should be treated differently for > the author than other people. The author does have current action to > take on the patch, namely moving it forward or withdrawing it. Right. So maybe for the patch author it appears either under "Your patches that need changes from you", or in a similar section that's just for stale patches that need to either be officially dropped or officially moved forward to an open CF. Whereas it'd be a little different (but not too different) for somebody who sees a patch because they're the reviewer/committer of record (the action item for such a person, if any, is to actually fully close the patch, or to nag the patch author). It probably makes sense to make stale/in limbo entries stick out like a sore thumb. They're *supposed* to be annoying. -- Peter Geoghegan
