On Wed, Mar 19, 2025 at 09:53:16AM +0800, Xuneng Zhou wrote: > I think these two conditions are good too. In a busy system, they are met > frequently, so the flush routine will be executed at least once every > second. Conversely, when WAL generation is low, there's simply less data to > record, and the flush frequency naturally decreases.
Hmm, yeah, perhaps this is acceptable. The changes in pgstat.c seem inconsistent, though, only moving the min interval while the max and idle times stay around. This also make me wonder if we should work towards extending pgstat_report_stat(), so as we save in GetCurrentTimestamp() while making the internals still local to pgstat.c. Or perhaps not in the scope of a backpatchable design. -- Michael
signature.asc
Description: PGP signature
