On Tue, Mar 18, 2025 at 10:31 AM Andrew Dunstan <and...@dunslane.net> wrote: > > On Mar 18, 2025, at 9:34 AM, Robert Haas <robertmh...@gmail.com> wrote: > > On Tue, Mar 18, 2025 at 9:27 AM Andrew Dunstan <and...@dunslane.net> wrote: > >> Maybe we could have a TAP test module that would run it but only if you > >> have "code-indent" in your PG_TEST_EXTRA. > > What is the argument against always testing this? > > Just a question if everyone wants to run this. Koel takes about 10s to run > the indent test.
Well, IMHO, that's pretty cheap insurance against having to push a second commit to fix indentation. But I guess one problem is not everyone may have pgindent installed locally. But at least I should get it set up here. I tried setting PG_TEST_EXTRA=code-indent locally and running 'meson test' and I didn't get a failure -- and 'git grep code-indent' returned nothing. Any tips? -- Robert Haas EDB: http://www.enterprisedb.com
