On Tue, Mar 18, 2025 at 01:37:02PM -0400, Andres Freund wrote: > I'd add a few more complications: > > - Create and test a relation that was rewritten, to ensure we test the > relfilenode != oid case and one that isn't rewritten.
+1 > - Perhaps create a tablespace? +1, I don't think we have much, if any, coverage of pg_upgrade with non-default tablespaces. > - Do we need a new old cluster for each of the modes? That seems like wasted > time? I guess it's required for --link... It'll also be needed for --swap. We could optionally save the old cluster for a couple of modes if we really wanted to. *shrug* I'll work on the first two... -- nathan
