Greg Sabino Mullane <htamf...@gmail.com> writes:
> Re-reviewed this patch: still compiles, tests pass, and does what it says
> on the tin. +1
Pushed with minor corrections:
* The patch still hadn't absorbed jian he's point that pg_dump main()
needs to fill ropt->no_policies from dopt.no_policies. It's possible
that that had no externally-visible effect, but just as a matter of
style we should fill the RestoreOptions fully.
* It seems better to me to implement the no_policies filter in
getPolicies() not dumpPolicy(). That way we don't waste effort
on retrieving catalog data we aren't going to use. It might be
problematic if we had to deal with dependency chains involving
policies, but AFAIK there is nothing that depends on a policy.
* I fixed a couple bits of sloppy alphabetization and updated
the Perl style in the test script.
regards, tom lane
