Andres Freund <and...@anarazel.de> writes: > While looking at the view I felt motivated to tackle the one FIXME in the > implementation of the view. Namely that the "error_desc" column wasn't > populated (the view did show that there was an error, but not what the error > was).
> Which lead me down a sad sad rabbit hole, largely independent of AIO. > ... > The main reason I wanted to write this up is that it seems that we're just > lacking some infrastructure here. Maybe. The mention of elog.c in the same breath with critical sections is already enough to scare me; we surely daren't invoke gettext() in a critical section, for instance. I feel the most we could hope for here is to report a constant string that would not get translated till later, outside the critical section. That seems less about infrastructure and more about how the AIO error handling/reporting code is laid out. In the meantime, if leaving the error out of this view is enough to make the problem go away, let's do that. regards, tom lane