On Wed, Mar 5, 2025, at 03:32, Andreas Karlsson wrote: > On 3/4/25 10:24 AM, Andreas Karlsson wrote: >> Rebased the patch to add support for OLD.* and NEW.*. > > Apparently the CI did not like that version. > > Andreas > > Attachments: > * v6-0001-Add-support-for-ON-CONFLICT-DO-SELECT-FOR.patch
+1 This patch adds a very useful feature. I looked over the patch and noted that it touches some areas and concepts that I don't feel sufficiently familiar with. For that reason, I'm removing myself as a reviewer, hoping that someone with the appropriate expertise will step in. That said, I read through the entire patch, and everything—code, comments, tests, and documentation—appears tidy and well-structured. I didn't spot any obvious errors or issues. I did notice a couple of minor nits in the comments: - The word "strength" is misspelled as "strengh" in a few places. - There's an extra "if" in the comment "Returns true if if we're done." Overall, the patch looks solid to me. /Joel
