On Tue, Mar 04, 2025 at 10:31:46AM +0100, Anthonin Bonnefoy wrote: > Saving the printQueryOpt when a command is pushed was an option I had > in mind if that was straightforward to implement. However, even with > savePsetInfo, you will need to save values like gfname and gset_prefix > since it impacts the output (it may make sense to move those in > printQueryOpt). This would also need to be saved for all commands, > like \close or \parse since we don't distinguish if a piped command > generates an output or not. So that definitely looks like it would add > a lot of complexity for limited benefit.
Yeah, same opinion here. I don't want this level of complexity with extra manipulations of printQueryOpt when fetching the results, either. I'm all for making these meta-commands to what we think is more natural, but not at the cost of a more complex logic in the result printing depending on what's been given by a meta-command when a query is pushed to a pipeline. > I took a stab at creating the \sendpipeline meta-command. I've also > realised there's a small leak where fname is currently not freed on > queries like 'select ... \bind \gx filename' when within a pipeline, > which is fixed in patch 0001. Indeed. Fixed this one for now. -- Michael
signature.asc
Description: PGP signature
