On 07/29/2018 05:11 PM, Tomas Vondra wrote: > > > On 07/29/2018 04:31 PM, Jeff Janes wrote: >> >> >> On Sat, Jul 28, 2018 at 9:54 PM, Tomas Vondra >> <tomas.von...@2ndquadrant.com <mailto:tomas.von...@2ndquadrant.com>> wrote: >> >> >> >> I've committed the first two parts, after a review and testing. >> >> >> I'm getting a compiler warning now: >> >> geo_ops.c: In function 'line_closept_point': >> geo_ops.c:2528:7: warning: variable 'retval' set but not used >> [-Wunused-but-set-variable] >> bool retval; >> > > Yeah, the variable is apparently only used in an assert. Will fix. >
This should fix it I guess, and it's how we deal with unused return values elsewhere. I've considered using USE_ASSERT_CHECKING here, but it seems rather ugly with that. I'll wait for Emre's opinion ... regards -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
diff --git a/src/backend/utils/adt/geo_ops.c b/src/backend/utils/adt/geo_ops.c index 621b5c33ef..7e53ab819c 100644 --- a/src/backend/utils/adt/geo_ops.c +++ b/src/backend/utils/adt/geo_ops.c @@ -2535,7 +2535,11 @@ line_closept_point(Point *result, LINE *line, Point *point) /* We drop a perpendicular to find the intersection point. */ line_construct(&tmp, point, line_invsl(line)); retval = line_interpt_line(&closept, line, &tmp); - Assert(retval); /* XXX: We need something better. */ + + /* For perpendicular lines, the intersection should exist. */ + Assert(retval); + + (void) retval; /* silence compiler warning in non-assert builds */ if (result != NULL) *result = closept;
