Jeff Davis <pg...@j-davis.com> writes: > I think you had mentioned upthread something about getting rid of the > table-driven logic, which is fine with me. Did you mean for that to > happen in this patch as well?
Per Corey's description of the patch (I didn't read it yet), some of that already happened. I want to get to buildfarm-green ASAP, so I'm content to leave other cosmetic changes for later. BTW, one cosmetic change that I'd like to see is that any tables that don't go away get marked "const". I tried to make that happen with attribute_stats.c's tables in my WIP patch upthread, but found that the need for const-ness would propagate to some utility functions and such, so I put the idea on the back burner. regards, tom lane