Re: Virtual generated columns

[Richard Guo]

On Mon, Feb 24, 2025 at 3:50 PM jian he <jian.universal...@gmail.com> wrote:
> On Sat, Feb 22, 2025 at 11:12 PM Richard Guo <guofengli...@gmail.com> wrote:
> > On Sat, Feb 22, 2025 at 11:55 PM Richard Guo <guofengli...@gmail.com> wrote:
> > > Attached are the updated patches to fix all the mentioned issues.  I
> > > plan to push them early next week after staring at the code for a bit
> > > longer, barring any objections.
> >
> > Sign... I neglected to make the change in 0001 that a Var newnode
> > compares its varlevelsup with 0 when deciding to wrap it in a
> > ReturningExpr.  I made this change in 0002 though, so maybe we're good
> > here.  Still, I'll fix this later.
> >
> i also noticed this issue...
>
> some minor comments about v7.

Thanks for reviewing.

Here are the updated patches with revised comments and some tweaks to
the commit messages.  I plan to push them in one or two days.

Thanks
Richard

v8-0001-Expand-virtual-generated-columns-in-the-planner.patch
Description: Binary data

v8-0002-Eliminate-code-duplication-in-replace_rte_variables-callbacks.patch
Description: Binary data