>> IMO, the set of cases where it's legitimate to mark individual struct >> fields as const is negligibly small, and this doesn't seem to be one >> of them. > > Thanks for the report, will fix. > >> BTW, as another nitpicky style matter: why do PGoauthBearerRequest >> etc. spell their struct tag names differently from their typedef names >> (that is, with/without an underscore)? That is not our project style >> anywhere else, and I'm failing to detect a good reason to do it here. > > Indeed it isn't, the only explanation is that I missed it. Will fix.
The attached diff passes CI and works for me, will revisit in the morning. -- Daniel Gustafsson
structfixups.diff
Description: Binary data
