Hi,
On 2025-02-21 11:04:49 -0500, Andrew Dunstan wrote:
> On 2025-02-21 Fr 10:50 AM, Andres Freund wrote:
> > > Can we explicitly set the MESON_BUILD_ROOT environment variable when
> > > running
> > > a test? With included patch for the src/tools/testwrap file, each instance
> > > gets an unique TCP port.
> > I don't like that, feels like a "namespace violation" to set a MESON_*
> > variable, why not set the top_builddir or a dedicated variable?
> >
> > And I don't think it should be done in testwrap, but to test_env in the
> > top-level meson.build.
> >
> > Something like the attached?
> >
>
> LGTM
Thanks for the quick review!
For some reason perltidy moves the $ENV{top_builddir} into the line with the =
once there's only one \n||. Somewhat annoying.
Pushed.
And thanks for the report, Roman!
Greetings,
Andres
