Dear hackers, Hi, I found the issue $SUBJECT. According to the doc [1]:
``` -d dbname --dbname=dbname The database to connect to. See the description of the actions for what this means in detail. The dbname can be a connection string. If so, connection string parameters will override any conflicting command line options. Defaults to the user name. ``` IIUC final statement implies --dbname can be omitted. If it is mandatory, it should be described in the synopsis part - not written now. However, the command would fail when -d is missed. ``` $ pg_recvlogical -U postgres --start -S test -f - pg_recvlogical: error: no database specified pg_recvlogical: hint: Try "pg_recvlogical --help" for more information. ``` ISTM the inconsistency is introduced since the initial commit. I think they should be unified either 1) update the doc or 2) accept when -d is not specified. Personally, I like 2nd approach, pg_recvlogical can follow the normal connection rule. I.e., a) Use PGDATABASE if specified b) Check 'U' and PGUSER and use it if specified c) Otherwise use the current OS user name Attached patch tries to implement the 2nd approach. How do you think? [1]: https://www.postgresql.org/docs/devel/app-pgrecvlogical.html Best regards, Hayato Kuroda FUJITSU LIMITED
0001-pg_recvlogical-accept-if-d-is-not-specified.patch
Description: 0001-pg_recvlogical-accept-if-d-is-not-specified.patch
