On Wednesday, January 29, 2025 8:19 PM Shlok Kyal <shlok.kyal....@gmail.com> wrote: > > I have addressed the comments. Here is an updated patch.
Thanks for updating the patch. The patches look mostly OK to me, I only have one minor comments in 0002. 1. +CREATE PUBLICATION pub_b_c_2 FOR TABLE tab_part2_1; +)); + +($result, $stdout, $stderr) = $node_C->psql( + 'postgres', " + CREATE SUBSCRIPTION sub_b_c CONNECTION '$node_B_connstr' PUBLICATION pub_b_c WITH (origin = none, copy_data = on); +"); The naming style of new publications and subscriptions doesn't seem consistent with existing ones in 030_origin. Best Regards, Hou zj
