Re: Log a warning in pg_createsubscriber for max_slot_wal_keep_size

[Shubham Khanna]

On Mon, Feb 17, 2025 at 4:06 PM Amit Kapila <amit.kapil...@gmail.com> wrote:
>
> On Thu, Jan 23, 2025 at 6:42 PM Shubham Khanna
> <khannashubham1...@gmail.com> wrote:
> >
> > Fixed the given comments. The attached patch contains the suggested changes.
> >
>
> I am fine with giving a WARNING for max_slot_wal_keep_size but I don't
> think we need a test for each and every setting required for
> pg_createsubscriber. This will add time to the tests without adding
> much value. So, I don't think this patch deserves an additional test.
>

I understand the concern that adding test cases for every required
setting in pg_createsubscriber may unnecessarily increase test
execution time without providing significant additional value.
Based on this, I have removed the additional test cases as they do not
offer substantial benefits to the overall test suite.

The attached Patch contains the suggested changes.

Thanks and regards,
Shubham Khanna.

v14-0001-Validate-max_slot_wal_keep_size-in-pg_createsubs.patch
Description: Binary data