On 14.02.2025 19:47, Nathan Bossart wrote:
On Thu, Feb 13, 2025 at 05:01:59PM -0600, Nathan Bossart wrote:
Okay, I took your suggestions in v7.
Committed. Thanks, David, Peter, and Daniel!
Hi,
Maybe I'm being picky, but in auto_explain, the parameters
log_min_duration and log_parameter_max_length do not follow the
conventions we have adopted. I mean we should use numerals instead of
words. I'm attaching a patch to fix this.
--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.
From 71274740583fcac642b6e74adabeeaf3992f2e1a Mon Sep 17 00:00:00 2001
From: Ilia Evdokimov <ilya.evdoki...@tantorlabs.ru>
Date: Mon, 17 Feb 2025 12:47:43 +0300
Subject: [PATCH v8] Standardize parameter descriptions in auto_explain
Align the descriptions of log_min_duration and log_parameter_max_length
in auto_explain with the formatting conventions used for other GUC parameters
according to 977d865 commit.
---
contrib/auto_explain/auto_explain.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/auto_explain/auto_explain.c b/contrib/auto_explain/auto_explain.c
index f1ad876e82..912abc42e8 100644
--- a/contrib/auto_explain/auto_explain.c
+++ b/contrib/auto_explain/auto_explain.c
@@ -93,7 +93,7 @@ _PG_init(void)
/* Define custom GUC variables. */
DefineCustomIntVariable("auto_explain.log_min_duration",
"Sets the minimum execution time above which plans will be logged.",
- "Zero prints all plans. -1 turns this feature off.",
+ "0 prints all plans. -1 turns this feature off.",
&auto_explain_log_min_duration,
-1,
-1, INT_MAX,
@@ -105,7 +105,7 @@ _PG_init(void)
DefineCustomIntVariable("auto_explain.log_parameter_max_length",
"Sets the maximum length of query parameters to log.",
- "Zero logs no query parameters, -1 logs them in full.",
+ "0 logs no query parameters, -1 logs them in full.",
&auto_explain_log_parameter_max_length,
-1,
-1, INT_MAX,
--
2.34.1
