On Mon, Feb 17, 2025 at 11:29 AM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Fri, Feb 14, 2025 at 5:30 PM Nisha Moond <nisha.moond...@gmail.com> wrote: > > > > Here is a summary of changes in v78: > > > > A few minor comments: > 1. > Slots that appear idle due to a disrupted connection between > + the publisher and subscriber are also excluded, as they are managed > by > + <link > linkend="guc-wal-sender-timeout"><varname>wal_sender_timeout</varname></link>. > ... > > How do we exclude the above kind of slots? I think it is trying to > cover the case where walsender is not exited even after the connection > is broken between publisher and subscriber. The point is quite > confusing and adds much less value. So, we can remove it. > > 2. > - * Returns true when any slot have got invalidated. > + * Returns true if there are any invalidated slots. > ... > > I find the existing comment more suitable for this function and easy to > follow. > > Apart from the above, I have changed a few other comments and minor > cosmetic cleanup. >
Here are the v79 patches with the above changes and comments from [1] incorporated. [1] https://www.postgresql.org/message-id/CAHut%2BPutqw%3D79SPh%2BEJZoS%2B98cJJvRRBmp-v6zqSRwngHey_ow%40mail.gmail.com -- Thanks, Nisha
v79-0001-Introduce-inactive_timeout-based-replication-slo.patch
Description: Binary data
v79-0002-Add-TAP-test-for-slot-invalidation-based-on-inac.patch
Description: Binary data
