On Thu, Jul 26, 2018 at 03:06:59PM +0000, Bossart, Nathan wrote:
> I took a look at 0001.

Thanks for the lookup.  0003 is the most simple in the set by the way.

> On 7/26/18, 12:24 AM, "Michael Paquier" <mich...@paquier.xyz> wrote:
> -     myrelid = RelationGetRelid(rel);
> +     myrelid = RangeVarGetRelidExtended(rv, AccessExclusiveLock,
> +         false, RangeVarCallbackForTruncate, NULL);
> 
> Should the flags argument be 0 instead of false?

Yes, those should be 0.  All patches are missing that.  It does not have
a bad consequence on the patch, still that's incorrect.
--
Michael

Attachment: signature.asc
Description: PGP signature

Reply via email to