On Tue, Feb 11, 2025 at 10:10 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > ... > The change in 0001 looks odd after seeing it in HTML format. We should > either add one empty line between two paragraphs otherwise it doesn't > appear good. Did you see multi-paragraphs in any other column > definitions? > > For the 0002 patch, I find the following changes as improvements, > * > <para> > - Note that for slots on the standby > to > + For standby slots > > * > On standby, this is useful for slots > - that are being synced from a primary server (whose > - <structfield>synced</structfield> field is <literal>true</literal>) > - so they know when the slot stopped being synchronized. > to > This helps standby slots > + track when synchronization was interrupted. > > Other than that, I find the current wording okay. >
Hi Amit, thanks for the feedback! ////// Patch 0001 The pg_replication_slots system view is unusual in that there can be entirely different descriptions of the same field depending on the context, such as: a- for logical slots b- for physical slots c- for primary servers versus standby servers IIUC your 0001 feedback says that a blank line might be ok, but just doing it for 'active_since' and nothing else makes it look odd. So, I have modified the 0001 patch to add blank lines separating those different contexts (e.g. a,b,c) for all fields. I think it improves the readability. In passing. - changed null to <literal>NULL</literal> - changed true to <literal>true</literal> - changed false to <literal>false</literal> ////// Patch 0002 Modified the text as suggested. ====== Kind Regards, Peter Smith. Fujitsu Australia
v2-0001-DOCS-pg_replication_slots.-Add-blank-lines.patch
Description: Binary data
v2-0002-DOCS-pg_replication_slots.-Improve-the-active_sin.patch
Description: Binary data
