On Tue, Feb 11, 2025 at 9:43 PM Peter Smith <smithpb2...@gmail.com> wrote: > > Hi. Here are some minor comments for the v18* patch set. > > ////////// > > Patch v18-0001 > > 1.1. Commit message > > A previously reported typo still exists: > > /noticeble/noticeable/ > > ////////// > > Patch v18-0002 > > 2.1 > +#define RBTXN_PREPARE_STATUS_FLAGS (RBTXN_IS_PREPARED | > RBTXN_SKIPPED_PREPARE | RBTXN_SENT_PREPARE) > + > > AFAICT bitmasks like this are more commonly named with a _MASK suffix. > > How about something like: > - RBTXN_PREPARE_MASK > - RBTXN_PREPARE_STATUS_MASK > - RBTXN_PREPARE_FLAGS_MASK >
Pushed both patches after addressing the above comments. Thank you for your review! Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
