On Sun, 2025-02-09 at 22:00 -0500, Corey Huinker wrote:
>
> 0002 - I've done some documentation rewording, mostly wording changes
> where behaviors surrounding data-only dumps are actually meant for
> any dump that has all schema excluded.
Comments on v45-0002:
* Why is generate_old_dump() passing optionally passing --no-statistics
to pg_dumpall along with --globals-only? If --globals-only is
specified, no stats are dumped anyway, right?
* The tag is still wrong: it is "STATISTICS DATA mytable" when it
should just be "mytable".
* What's the logic behind the pg_dumpall options? The docs say
it should support the new pg_dump options, but they don't seem to work.
* The enum entryType casing is unconventional. How about a type name of
TocEntryType and values like STATS_TOC_ENTRY.
* The pg_dump test suite time has increased by ~50%. If some tests are
superfluous, please remove them.
Regards,
Jeff Davis
