On Tue, 4 Feb 2025 at 22:36, Peter Eisentraut <pe...@eisentraut.org> wrote: > > Yeah, this is quite contorted. I have renamed it like you suggested.
I looked over this again and I think the patch is in good shape to be committed. One thought that occurred to me was whether it would be better for the psql describe output (and maybe also pg_dump) to explicitly output "virtual" for columns of this kind. I know that that's the default for generated columns, but someone reading the output might not know or remember that, so perhaps it would be helpful to be explicit. Regards, Dean