> On 5 Feb 2025, at 13:30, Japin Li <japi...@hotmail.com> wrote: > When reviewing patch [1], I find that the static class specifier is > unnecessary > for the variables sp and ep in the function px_crypt_md5().
From a quick first inspection (and running the tests with the patch applied) I agree with this, these variables do not need to be static. I'll stare a bit more at this to make sure but seems like the right patch. -- Daniel Gustafsson
