On Mon, Jan 27, 2025 at 03:04:55PM +0530, Ashutosh Bapat wrote: > PFA patch with rebased on the latest HEAD and conflicts fixed.
Thanks for the new patch. Hmm. I was reading through the patch and there is something that clearly stands out IMO: the new compare_dumps(). It is in Utils.pm, and it acts as a wrapper of `diff` with its formalized output format. It is not really about dumps, but about file comparisons. This should be renamed compare_files(), with internals adjusted as such, and reused in all the existing tests. Good idea to use that in 027_stream_regress.pl, actually. I'll go extract that first, to reduce the presence of `diff` in the whole set of TAP tests. AdjustDump.pm looks like a fine concept as it stands. I still need to think more about it. It feels like we don't have the most optimal interface, though, but perhaps that will be clearer once compare_dumps() is moved out of the way. -- Michael
signature.asc
Description: PGP signature
